fix sonar

src/main/java/com/viettel/campaign/service/impl/CampaignCfgServiceImpl.java

@@ -44,8 +44,7 @@ public class CampaignCfgServiceImpl implements CampaignCfgService {
         ResultDTO resultDTO = new ResultDTO();
         SessionFactory sessionFactory = HibernateUtil.getSessionFactory();
 
-        Session session = sessionFactory.openSession();
-        session.beginTransaction();
+        Session session = null;
 
         if (DataUtil.isNullOrZero(companySiteId)) {
             resultDTO.setErrorCode(Constants.ApiErrorCode.ERROR);
@@ -54,6 +53,8 @@ public class CampaignCfgServiceImpl implements CampaignCfgService {
         }
 
         try {
+            session = sessionFactory.openSession();
+            session.beginTransaction();
 //            StringBuilder sqlStrBuilder = new StringBuilder();
 //            sqlStrBuilder.append(SQLBuilder.getSqlQueryById(SQLBuilder.SQL_MODULE_CAMPAIGN_STATUS_MNG, "findAll-CampaignCompleteCode"));
             StringBuilder sb = new StringBuilder();
@@ -132,7 +133,7 @@ public class CampaignCfgServiceImpl implements CampaignCfgService {
             resultDTO.setDescription(Constants.ApiErrorDesc.ERROR);
             logger.error(e.getMessage(), e);
         } finally {
-            session.close();
+            if(session != null) session.close();
         }
 
         return resultDTO;
@@ -278,8 +279,7 @@ public class CampaignCfgServiceImpl implements CampaignCfgService {
         ResultDTO resultDTO = new ResultDTO();
         SessionFactory sessionFactory = HibernateUtil.getSessionFactory();
 
-        Session session = sessionFactory.openSession();
-        session.beginTransaction();
+        Session session = null;
 
         if (DataUtil.isNullOrZero(completeCodeDTO.getCompanySiteId())) {
             resultDTO.setErrorCode(Constants.ApiErrorCode.ERROR);
@@ -288,6 +288,8 @@ public class CampaignCfgServiceImpl implements CampaignCfgService {
         }
 
         try {
+            session = sessionFactory.openSession();
+            session.beginTransaction();
 //            StringBuilder sqlStrBuilder = new StringBuilder();
 //            sqlStrBuilder.append(SQLBuilder.getSqlQueryById(SQLBuilder.SQL_MODULE_CAMPAIGN_STATUS_MNG, "get-max-value-completevalue"));
             StringBuilder sb = new StringBuilder();
@@ -323,9 +325,9 @@ public class CampaignCfgServiceImpl implements CampaignCfgService {
             resultDTO.setDescription(Constants.ApiErrorDesc.ERROR);
             logger.error(e.getMessage(), e);
         } finally {
-            session.close();
-            return resultDTO;
+            if(session != null) session.close();
         }
+        return resultDTO;
     }
 
     @Override
@@ -367,8 +369,7 @@ public class CampaignCfgServiceImpl implements CampaignCfgService {
         ResultDTO resultDTO = new ResultDTO();
         SessionFactory sessionFactory = HibernateUtil.getSessionFactory();
 
-        Session session = sessionFactory.openSession();
-        session.beginTransaction();
+        Session session = null;
 
         if (DataUtil.isNullOrZero(campaignCompleteCodeId)) {
             resultDTO.setErrorCode(Constants.ApiErrorCode.ERROR);
@@ -377,6 +378,8 @@ public class CampaignCfgServiceImpl implements CampaignCfgService {
         }
 
         try {
+            session = sessionFactory.openSession();
+            session.beginTransaction();
 //            StringBuilder sqlStrBuilder = new StringBuilder();
 //            sqlStrBuilder.append(SQLBuilder.getSqlQueryById(SQLBuilder.SQL_MODULE_CAMPAIGN_STATUS_MNG,"findCampaignCodeById"));
 
@@ -437,7 +440,7 @@ public class CampaignCfgServiceImpl implements CampaignCfgService {
             resultDTO.setDescription(Constants.ApiErrorDesc.ERROR);
             logger.error(e.getMessage(), e);
         } finally {
-            session.close();
+            if(session != null) session.close();
         }
 
         return resultDTO;